spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #15361: [SPARK-17765][SQL] Support for writing out user-d...
Date Sun, 23 Oct 2016 06:13:11 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15361#discussion_r84590714
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ---
    @@ -246,6 +246,9 @@ private[hive] trait HiveInspectors {
        * Wraps with Hive types based on object inspector.
        */
       protected def wrapperFor(oi: ObjectInspector, dataType: DataType): Any => Any =
oi match {
    +    case _ if dataType.isInstanceOf[UserDefinedType[_]] =>
    --- End diff --
    
    Oh, actually, I forgot that this path is doing a pattern matching via `ObjectInspector`
not with `DataType`. I just remember I put this first for this reason (we should check `dataType`
regardless of `ObjectInspector` first).
    
    I definitely can avoid this via fixing more than here but I guess it is fine as it is
because this is not in the critical path. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message