spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request #15513: [SPARK-17963][SQL][Documentation] Add examples (e...
Date Sat, 22 Oct 2016 19:29:26 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15513#discussion_r84583708
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
---
    @@ -43,11 +43,20 @@ import org.apache.spark.util.Utils
      *                 and the second element should be a literal string for the method name,
      *                 and the remaining are input arguments to the Java method.
      */
    -// scalastyle:off line.size.limit
     @ExpressionDescription(
    -  usage = "_FUNC_(class,method[,arg1[,arg2..]]) calls method with reflection",
    -  extended = "> SELECT _FUNC_('java.util.UUID', 'randomUUID');\n c33fb387-8500-4bfa-81d2-6e0e3e930df2")
    -// scalastyle:on line.size.limit
    +  usage = "_FUNC_(class, method[, arg1[, arg2 ..]]) - Calls method with reflection.",
    +  extended = """
    +    Arguments:
    +      class - a string literal that represents a fully-qualified class name.
    +      method - a string literal that represents a method name.
    +      arg - a string literal that represents arguments for the method.
    --- End diff --
    
    is it always literal?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message