spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jodersky <...@git.apache.org>
Subject [GitHub] spark pull request #15398: [SPARK-17647][SQL] Fix backslash escaping in 'LIK...
Date Sat, 22 Oct 2016 18:49:36 GMT
Github user jodersky commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15398#discussion_r84582746
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
---
    @@ -68,7 +68,20 @@ trait StringRegexExpression extends ImplicitCastInputTypes {
      * Simple RegEx pattern matching function
      */
     @ExpressionDescription(
    -  usage = "str _FUNC_ pattern - Returns true if str matches pattern and false otherwise.")
    +  usage = "str _FUNC_ pattern - Returns true if str matches pattern, " +
    +    "null if any arguments are null, false otherwise.",
    +  extended =
    +    "The pattern is a string which is matched literally, with exception to the following
" +
    +    "special symbols:\n\n" +
    +    "    _ matches any one character in the input (similar to . in posix " +
    +    "regular expressions)\n\n" +
    +    "    % matches zero ore more characters in the input (similar to .* in " +
    +    "posix regular expressions)\n\n" +
    +    "The escape character is '\\'. If an escape character precedes a special symbol or
" +
    +    "another escape character, the following character is matched literally, For example,
" +
    +    "the expression `<path> like \\%SystemDrive\\%\\\\Users%` will match any `<path>`
that " +
    +    "starts with '%SystemDrive%\\Users'. It is invalid to escape any other character.\n\n"
+
    +    "Use RLIKE to match with standard regular expressions.")
    --- End diff --
    
    ack


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message