spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request #15517: [SPARK-17972][SQL] Build Datasets upon `withCache...
Date Thu, 20 Oct 2016 23:26:03 GMT
Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15517#discussion_r84395740
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
---
    @@ -66,11 +66,13 @@ class QueryExecution(val sparkSession: SparkSession, val logical:
LogicalPlan) {
     
       lazy val withCachedData: LogicalPlan = {
         assertAnalyzed()
    -    assertSupported()
    --- End diff --
    
    This line is actually moved to `optimizedPlan`. It's for fixing the streaming test failures.
    
    Although streaming queries doesn't use `QueryExecution` for actual execution, it somehow
triggers this line after changes made in the previous commit and throws exception. Not quite
familiar with structured streaming though, I may missed something here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message