spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request #15513: [WIP][SPARK-17963][SQL][Documentation] Add exampl...
Date Mon, 17 Oct 2016 13:44:28 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15513#discussion_r83644370
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala
---
    @@ -121,8 +176,19 @@ case class XPathFloat(xml: Expression, path: Expression) extends
XPathExtract {
     }
     
     @ExpressionDescription(
    -  usage = "_FUNC_(xml, xpath) - Returns a double value that matches the xpath expression",
    -  extended = "> SELECT _FUNC_('<a><b>1</b><b>2</b></a>','sum(a/b)');\n3.0")
    +  usage =
    +    """
    +      _FUNC_(xml, xpath) - Returns a short value that matches the xpath expression.
    +
    +        Arguments:
    +          xml - string type that represents XML documentation.
    +          path - string type literal that represents xpath expression.
    --- End diff --
    
    documentation -> document?
    xpath -> XPath
    (Here and in a few other places)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message