spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From felixcheung <...@git.apache.org>
Subject [GitHub] spark issue #15493: [SPARK-17946][PYSPARK] Python crossJoin API similar to S...
Date Sun, 16 Oct 2016 04:10:48 GMT
Github user felixcheung commented on the issue:

    https://github.com/apache/spark/pull/15493
  
    That's a great point. Currently R is the same as Python in that when `joinExpr` is `NULL`
(R) or `on` is `None` (Python), CrossJoin is assumed. (Python [here](https://github.com/apache/spark/pull/15493/files#diff-6fc344560230bf0ef711bb9b5573f1faR650))
    
    Problem is by default `joinExpr = NULL` (R) and `on = None` (Python) - one approach is
to change both defaults, so that when omitted, they don't default to CrossJoin.
    Another approach is to additional ask for `joinType` or `how` of a new `cross_join` -
but this could be a bigger change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message