spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dilipbiswal <...@git.apache.org>
Subject [GitHub] spark pull request #15495: [SPARK-17620][SQL] Determine Serde by hive.defaul...
Date Fri, 14 Oct 2016 22:50:31 GMT
Github user dilipbiswal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15495#discussion_r83514164
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
    @@ -587,6 +594,30 @@ class SQLQuerySuite extends QueryTest with SQLTestUtils with TestHiveSingleton
{
         }
       }
     
    +  test("CTAS with default fileformat") {
    +    val table = "ctas1"
    +    val ctas = s"CREATE TABLE IF NOT EXISTS $table SELECT key k, value FROM src"
    +    withSQLConf(SQLConf.CONVERT_CTAS.key -> "true") {
    +      withSQLConf("hive.default.fileformat" -> "textfile") {
    +        withTable(table) {
    +          sql(ctas)
    +          // We should use parquet here as that is the default datasource fileformat.
The default
    +          // datasource file format is controlled by `spark.sql.sources.default` configuration.
    +          // This testcase verifies that setting `hive.default.fileformat` has no impact
on
    +          // the target table's fileformat in case of CTAS.
    +          assert(sessionState.conf.defaultDataSourceName === "parquet")
    +          checkRelation(tableName = table, isDataSourceTable = true, format = "parquet")
    --- End diff --
    
    In Scala 2.10, we need to name all the fields when we use named parameters. This is the
reason for build failure while using scala 2.10


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message