spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request #15382: [SPARK-17810] [SQL] Default spark.sql.warehouse.d...
Date Fri, 14 Oct 2016 19:23:32 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15382#discussion_r83485770
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -757,7 +758,10 @@ private[sql] class SQLConf extends Serializable with CatalystConf
with Logging {
     
       def variableSubstituteDepth: Int = getConf(VARIABLE_SUBSTITUTE_DEPTH)
     
    -  def warehousePath: String = new Path(getConf(WAREHOUSE_PATH)).toString
    +  def warehousePath: String = {
    +    val path = new Path(getConf(WAREHOUSE_PATH))
    +    FileSystem.get(path.toUri, new Configuration()).makeQualified(path).toString
    --- End diff --
    
    Can we split the difference here and treat those two as different issues?
    
    - for this bug, let's hardcode `.transform(new File(_).toURI().toString())` into the config
constant definition; that's on par with the previous version of this code modified in 11a6844beb,
which hardcoded the `file:` scheme into the default value.
    
    - separately, if it's a real issue, let's make changes to make this support non-local
directories.
    
    That way we fix the immediate issue and can have more discussions about how to properly
solve the other and maybe even fix `resolveURI`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message