spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sitalkedia <...@git.apache.org>
Subject [GitHub] spark pull request #15408: [SPARK-17839][CORE] Use Nio's directbuffer instea...
Date Fri, 14 Oct 2016 18:26:54 GMT
Github user sitalkedia commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15408#discussion_r83476597
  
    --- Diff: core/src/main/java/org/apache/spark/io/NioBufferedFileInputStream.java ---
    @@ -72,30 +74,35 @@ private boolean refill() throws IOException {
       }
     
       @Override
    -  public int read() throws IOException {
    +  public synchronized int read() throws IOException {
         if (!refill()) {
           return -1;
         }
         return byteBuffer.get() & 0xFF;
       }
     
       @Override
    -  public int read(byte[] b, int offset, int len) throws IOException {
    +  public synchronized int read(byte[] b, int offset, int len) throws IOException {
         if (!refill()) {
           return -1;
         }
    +    if ((offset | len | (offset + len) | (b.length - (offset + len))) < 0) {
    --- End diff --
    
    @srowen - Agreed, the condition was little confusing. Changed it to make it clearer. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message