spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request #9766: [SPARK-11775][PYSPARK][SQL] Allow PySpark to regis...
Date Wed, 12 Oct 2016 17:43:14 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9766#discussion_r83056607
  
    --- Diff: python/pyspark/sql/context.py ---
    @@ -202,6 +202,32 @@ def registerFunction(self, name, f, returnType=StringType()):
             """
             self.sparkSession.catalog.registerFunction(name, f, returnType)
     
    +    @ignore_unicode_prefix
    +    @since(2.1)
    +    def registerJavaFunction(self, name, javaClassName, returnType=None):
    +        """Register a java UDF so it can be used in SQL statements.
    +
    +        In addition to a name and the function itself, the return type can be optionally
specified.
    +        When the return type is not given it would infer the returnType via reflection.
    --- End diff --
    
    nit: its a little odd to mix `return type` with `returnType`.  Perhaps, "When the return
type is not specified we attempt to infer it using reflection"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message