spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #9973: [SPARK-11989][SQL] Only use commit in JDBC data so...
Date Wed, 12 Oct 2016 16:51:25 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9973#discussion_r83049327
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
    @@ -175,14 +187,18 @@ object JdbcUtils extends Logging {
           } finally {
             stmt.close()
           }
    -      conn.commit()
    +      if (supportsTransactions) {
    +        conn.commit()
    --- End diff --
    
    When the dataFrame has duplicate keys and the target tables have the unique constraints,
we could see the non-deterministic results at the target tables, since some partitions containing
duplicate keys could be rolled back.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message