spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request #15423: [SPARK-17860][SQL] SHOW COLUMN's database conflic...
Date Wed, 12 Oct 2016 05:16:38 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15423#discussion_r82937473
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
    @@ -207,6 +208,7 @@ class SQLQueryTestSuite extends QueryTest with SharedSQLContext {
         // Returns true if the plan is supposed to be sorted.
         def isSorted(plan: LogicalPlan): Boolean = plan match {
           case _: Join | _: Aggregate | _: Generate | _: Sample | _: Distinct => false
    +      case _: ShowColumnsCommand => true
    --- End diff --
    
    +1 as mentioned in previous comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message