spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request #15428: [SPARK-17219][ML] enchanced NaN value handling in...
Date Tue, 11 Oct 2016 08:06:40 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15428#discussion_r82741770
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala ---
    @@ -128,8 +145,9 @@ object Bucketizer extends DefaultParamsReadable[Bucketizer] {
        * Binary searching in several buckets to place each data point.
        * @throws SparkException if a feature is < splits.head or > splits.last
        */
    -  private[feature] def binarySearchForBuckets(splits: Array[Double], feature: Double):
Double = {
    -    if (feature.isNaN) {
    +  private[feature] def binarySearchForBuckets
    +  (splits: Array[Double], feature: Double, flag: String): Double = {
    --- End diff --
    
    Nit: I think the convention is to leave the open paren on the previous line
    
    Doesn't this need to handle "skip" and "error"? throw an exception on NaN if "error" or
ignore it if "skip"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message