spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sethah <...@git.apache.org>
Subject [GitHub] spark pull request #15342: [SPARK-11560] [MLLIB] Optimize KMeans implementat...
Date Mon, 10 Oct 2016 21:54:22 GMT
Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15342#discussion_r82690396
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala ---
    @@ -499,13 +414,38 @@ object KMeans {
        * @param data Training points as an `RDD` of `Vector` types.
        * @param k Number of clusters to create.
        * @param maxIterations Maximum number of iterations allowed.
    +   * @param initializationMode The initialization algorithm. This can either be "random"
or
    +   *                           "k-means||". (default: "k-means||")
    +   * @param seed Random seed for cluster initialization. Default is to generate seed
based
    +   *             on system time.
    +   */
    +  @Since("2.1.0")
    +  def train(data: RDD[Vector],
    --- End diff --
    
    minor: style should match other train signatures


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message