spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request #15389: [SPARK-17817][PySpark] PySpark RDD Repartitioning...
Date Mon, 10 Oct 2016 04:56:07 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15389#discussion_r82544055
  
    --- Diff: python/pyspark/rdd.py ---
    @@ -2029,7 +2028,11 @@ def coalesce(self, numPartitions, shuffle=False):
             >>> sc.parallelize([1, 2, 3, 4, 5], 3).coalesce(1).glom().collect()
             [[1, 2, 3, 4, 5]]
             """
    -        jrdd = self._jrdd.coalesce(numPartitions, shuffle)
    +        if shuffle:
    +            data_java_rdd = self._to_java_object_rdd().coalesce(numPartitions, shuffle)
    --- End diff --
    
    would be great to add some inline comment explaining why this is necessary. otherwise
somebody can just come in 6 month from now and change this back to `jrdd = self._jrdd.coalesce(numPartitions,
shuffle)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message