spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #15292: [SPARK-17719][SPARK-17776][SQL] Unify and tie up ...
Date Fri, 07 Oct 2016 05:08:24 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15292#discussion_r82329644
  
    --- Diff: docs/sql-programming-guide.md ---
    @@ -1014,16 +1014,31 @@ bin/spark-shell --driver-class-path postgresql-9.4.1207.jar --jars
postgresql-9.
     {% endhighlight %}
     
     Tables from the remote database can be loaded as a DataFrame or Spark SQL Temporary table
using
    -the Data Sources API. The following options are supported:
    +the Data Sources API. The following case-sensitive options are supported:
     
     <table class="table">
       <tr><th>Property Name</th><th>Meaning</th></tr>
       <tr>
         <td><code>url</code></td>
         <td>
    -      The JDBC URL to connect to.
    +      The JDBC URL to connect to. It might contain user and password information. e.g.,
<code>jdbc:postgresql://localhost/test?user=fred&password=secret</code>
         </td>
       </tr>
    +
    +  <tr>
    +    <td><code>user</code></td>
    +    <td>
    +      The user to connect as.
    --- End diff --
    
    Sorry, after rethinking it, I think we do not need `user` and `password` here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message