spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request #15352: [SPARK-17780][SQL]Report Throwable to user in Str...
Date Wed, 05 Oct 2016 20:28:56 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15352#discussion_r82063048
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamTest.scala ---
    @@ -322,7 +322,6 @@ trait StreamTest extends QueryTest with SharedSQLContext with Timeouts
{
                   new UncaughtExceptionHandler {
                     override def uncaughtException(t: Thread, e: Throwable): Unit = {
                       streamDeathCause = e
    -                  testThread.interrupt()
    --- End diff --
    
    Remove this line because the added test reaches here and interrupt it will make `awaitTermination`
fails with `InterruptException`. It's fine to remove it since the worse case is just waiting
for 10 seconds to fail a test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message