spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request #15307: [SPARK-17731][SQL][STREAMING] Metrics for structu...
Date Wed, 05 Oct 2016 02:00:56 GMT
Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15307#discussion_r81889488
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
    @@ -525,8 +645,62 @@ class StreamExecution(
       case object TERMINATED extends State
     }
     
    -object StreamExecution {
    +object StreamExecution extends Logging {
       private val _nextId = new AtomicLong(0)
     
    +  /**
    +   * Get the number of input rows from the executed plan of the trigger
    +   * @param triggerExecutionPlan Execution plan of the trigger
    +   * @param triggerLogicalPlan Logical plan of the trigger, generated from the query
logical plan
    +   * @param sourceToDataframe Source to DataFrame returned by the source.getBatch in
this trigger
    +   */
    +  def getNumInputRowsFromTrigger(
    --- End diff --
    
    We could test it using the listener, but the test will be very indirect and probably look
a lot more convoluted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message