spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayousterhout <...@git.apache.org>
Subject [GitHub] spark pull request #12775: [SPARK-14958][Core] Failed task not handled when ...
Date Tue, 04 Oct 2016 19:48:13 GMT
Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12775#discussion_r81835387
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskResultGetter.scala ---
    @@ -135,8 +135,9 @@ private[spark] class TaskResultGetter(sparkEnv: SparkEnv, scheduler:
TaskSchedul
                   logError(
                     "Could not deserialize TaskEndReason: ClassNotFound with classloader
" + loader)
                 case ex: Exception => // No-op
    +          } finally {
    +            scheduler.handleFailedTask(taskSetManager, tid, taskState, reason)
    --- End diff --
    
    Can you add a comment here saying something like:
    "If there's an error while deserializing the TaskEndReason, this Runnable will die.  Still
tell the scheduler about the task failure, to avoid a hang where the scheduler thinks the
task is still running."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message