spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkbradley <...@git.apache.org>
Subject [GitHub] spark pull request #15148: [SPARK-5992][ML] Locality Sensitive Hashing
Date Mon, 03 Oct 2016 18:17:14 GMT
Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15148#discussion_r81601289
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
    @@ -0,0 +1,338 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.ml.feature
    +
    +import scala.util.Random
    +
    +import org.apache.spark.ml.{Estimator, Model}
    +import org.apache.spark.ml.linalg.{Vector, VectorUDT}
    +import org.apache.spark.ml.param.{IntParam, ParamMap, ParamValidators}
    +import org.apache.spark.ml.param.shared.{HasInputCol, HasOutputCol}
    +import org.apache.spark.ml.util.SchemaUtils
    +import org.apache.spark.sql._
    +import org.apache.spark.sql.expressions.UserDefinedFunction
    +import org.apache.spark.sql.functions._
    +import org.apache.spark.sql.types._
    +
    +/**
    + * Params for [[LSH]].
    + */
    +private[ml] trait LSHParams extends HasInputCol with HasOutputCol {
    +  /**
    +   * Param for the dimension of LSH OR-amplification.
    +   *
    +   * In this implementation, we use LSH OR-amplification to reduce the false negative
rate. This
    +   * param is the dimension of the amplification. The higher the dimension is, the lower
the false
    +   * negative rate.
    +   * @group param
    +   */
    +  final val outputDim: IntParam = new IntParam(this, "outputDim", "output dimension",
    --- End diff --
    
    Include more description in the Param's built-in doc:
    "output dimension" -> "output dimension, where increasing dimensionality lowers the
false negative rate"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message