Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: sethah <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-11119-spark@git.apache.org>
In-Reply-To: <git-pr-11119-spark@git.apache.org>
Subject: [GitHub] spark pull request #11119: [SPARK-10780][ML] Add an initial model to kmeans
Content-Type: text/plain
Message-Id: <20160928022835.19DF2DFF56@git1-us-west.apache.org>
Date: Wed, 28 Sep 2016 02:28:35 +0000 (UTC)
archived-at: Wed, 28 Sep 2016 02:28:37 -0000

Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11119#discussion_r80833730
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
    @@ -300,15 +301,23 @@ private[ml] object DefaultParamsWriter {
           paramMap: Option[JValue] = None): String = {
         val uid = instance.uid
         val cls = instance.getClass.getName
    -    val params = instance.extractParamMap().toSeq.asInstanceOf[Seq[ParamPair[Any]]]
    +    val params = instance.extractParamMap().toSeq
    +      .filter(_.param.name != "initialModel").asInstanceOf[Seq[ParamPair[Any]]]
         val jsonParams = paramMap.getOrElse(render(params.map { case ParamPair(p, v) =>
           p.name -> parse(p.jsonEncode(v))
         }.toList))
    +    // If the instance has an "initialModel" param and the param is defined, then the initial model
    +    // will be saved along with the instance.
    +    val initialModelFlag =
    +      instance.hasParam("initialModel") && instance.isDefined(instance.getParam("initialModel"))
         val basicMetadata = ("class" -> cls) ~
           ("timestamp" -> System.currentTimeMillis()) ~
           ("sparkVersion" -> sc.version) ~
           ("uid" -> uid) ~
    -      ("paramMap" -> jsonParams)
    +      ("paramMap" -> jsonParams) ~
    +      // TODO: Figure out more robust way to detect the existing of the initialModel.
    --- End diff --
    
    If we're going to leave it as a TODO, let's have a Jira for it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org