Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: vanzin <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-15112-spark@git.apache.org>
In-Reply-To: <git-pr-15112-spark@git.apache.org>
Subject: [GitHub] spark pull request #15112: [RFC][SPARK-17549][sql] Only collect table size s...
Content-Type: text/plain
Message-Id: <20160915212022.E1FCCE00C4@git1-us-west.apache.org>
Date: Thu, 15 Sep 2016 21:20:22 +0000 (UTC)
archived-at: Thu, 15 Sep 2016 21:20:25 -0000

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15112#discussion_r79064451
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala ---
    @@ -910,14 +910,19 @@ object CodeGenerator extends Logging {
         codeAttrField.setAccessible(true)
         classes.foreach { case (_, classBytes) =>
           CodegenMetrics.METRIC_GENERATED_CLASS_BYTECODE_SIZE.update(classBytes.length)
    -      val cf = new ClassFile(new ByteArrayInputStream(classBytes))
    -      cf.methodInfos.asScala.foreach { method =>
    -        method.getAttributes().foreach { a =>
    -          if (a.getClass.getName == codeAttr.getName) {
    -            CodegenMetrics.METRIC_GENERATED_METHOD_BYTECODE_SIZE.update(
    -              codeAttrField.get(a).asInstanceOf[Array[Byte]].length)
    +      try {
    +        val cf = new ClassFile(new ByteArrayInputStream(classBytes))
    +        cf.methodInfos.asScala.foreach { method =>
    +          method.getAttributes().foreach { a =>
    +            if (a.getClass.getName == codeAttr.getName) {
    +              CodegenMetrics.METRIC_GENERATED_METHOD_BYTECODE_SIZE.update(
    +                codeAttrField.get(a).asInstanceOf[Array[Byte]].length)
    +            }
               }
             }
    --- End diff --
    
    But without this fix you can't read the table I described in the bug at all, because SQL just blows up. If you want a separate patch just for that ok, but seems like overkill to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org