Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: clockfly <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-15024-spark@git.apache.org>
In-Reply-To: <git-pr-15024-spark@git.apache.org>
Subject: [GitHub] spark pull request #15024: [SPARK-17470][SQL] unify path for data source tab...
Content-Type: text/plain
Message-Id: <20160913035950.1B830DFD4C@git1-us-west.apache.org>
Date: Tue, 13 Sep 2016 03:59:50 +0000 (UTC)
archived-at: Tue, 13 Sep 2016 03:59:52 -0000

Github user clockfly commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15024#discussion_r78493500
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala ---
    @@ -435,13 +435,13 @@ case class DataSource(
             //  1. Only one output path can be specified on the write path;
             //  2. Output path must be a legal HDFS style file system path;
             //  3. It's OK that the output path doesn't exist yet;
    -        val caseInsensitiveOptions = new CaseInsensitiveMap(options)
    -        val outputPath = {
    -          val path = new Path(caseInsensitiveOptions.getOrElse("path", {
    -            throw new IllegalArgumentException("'path' is not specified")
    -          }))
    +        val allPaths = paths ++ new CaseInsensitiveMap(options).get("path")
    --- End diff --
    
    Is it possible that both `paths` and `options` contains the same path string?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org