Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: sethah <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-14834-spark@git.apache.org>
In-Reply-To: <git-pr-14834-spark@git.apache.org>
Subject: [GitHub] spark pull request #14834: [SPARK-17163][ML][WIP] Unified LogisticRegression...
Content-Type: text/plain
Message-Id: <20160908230208.98E12DFD9F@git1-us-west.apache.org>
Date: Thu,  8 Sep 2016 23:02:08 +0000 (UTC)
archived-at: Thu, 08 Sep 2016 23:02:10 -0000

Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14834#discussion_r78104785
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala ---
    @@ -232,6 +363,47 @@ class LogisticRegressionSuite
         }
       }
     
    +  test("coefficients and intercept methods") {
    +    val mlr = new LogisticRegression().setMaxIter(1)
    +    val mlrModel = mlr.fit(smallMultinomialDataset)
    +    val thrownCoef = intercept[SparkException] {
    +      mlrModel.coefficients
    +    }
    +    val thrownIntercept = intercept[SparkException] {
    +      mlrModel.intercept
    +    }
    +    assert(thrownCoef.getMessage().contains("use coefficientMatrix instead"))
    +    assert(thrownIntercept.getMessage().contains("use interceptVector instead"))
    +
    +    val blr = new LogisticRegression().setMaxIter(1)
    --- End diff --
    
    In tests like these, perhaps we should explicitly set the family to be certain of the code path. We already have a test to check the family detection code. I'll add this in my next commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org