Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: clockfly <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-14897-spark@git.apache.org>
In-Reply-To: <git-pr-14897-spark@git.apache.org>
Subject: [GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view
Content-Type: text/plain
Message-Id: <20160901222912.0F288E0061@git1-us-west.apache.org>
Date: Thu,  1 Sep 2016 22:29:12 +0000 (UTC)
archived-at: Thu, 01 Sep 2016 22:29:13 -0000

Github user clockfly commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14897#discussion_r77265693
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
    @@ -255,3 +287,43 @@ case class AlterViewAsCommand(
         session.sessionState.catalog.alterTable(updatedViewMeta)
       }
     }
    +
    +/**
    + * Drops a view which matches the given name.
    + *
    + * If the view name contains database prefix, this command will drop a permanent view matching the
    + * given name, or throw an exception if view not exist. Else, this command will try to drop a local
    + * temporary view first, if view not exist, try global temporary view next, if still not exist, try
    --- End diff --
    
    I think it is a bit risky to provide user the ability to drop a global view implicitly. 
    
    I think all global view modification commands should be done explicitly, including create, drop, alter..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org