spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From djvulee <...@git.apache.org>
Subject [GitHub] spark pull request #15052: [SPARK-17500][PySpark]Make DiskBytesSpilled metri...
Date Sun, 11 Sep 2016 19:54:00 GMT
GitHub user djvulee opened a pull request:

    https://github.com/apache/spark/pull/15052

    [SPARK-17500][PySpark]Make DiskBytesSpilled metric in PySpark shuffle right

    ## What changes were proposed in this pull request?
    
    The origin way increases the DiskBytesSpilled metric with the file size during each spill
in ExternalMerger && ExternalGroupBy, but we only need the last size.
    
    ## How was this patch tested?
    
    No extra tests, because this just update the metrics
    
    Author: Li Hu <lihu@bytedance.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/djvulee/spark PyDiskSpillMetric

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/15052.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15052
    
----
commit 1b90b0dd61c22ffba6d578f73cf5aca88629b1be
Author: DjvuLee <lihu@bytedance.com>
Date:   2016-09-11T19:41:32Z

    Make DiskBytesSpilled metric in PySpark shuffle right
    
    The origin way increase the DiskBytesSpilled metric with the file
    size during each spill in ExternalMerger && ExternalGroupBy, but we only need
the last size.
    
    No extra Tests, because this just update the metrics
    
    Author: Li Hu <lihu@bytedance.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message