spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request #14943: [SPARK-15891][yarn] Clean up some logging in the ...
Date Fri, 02 Sep 2016 22:30:19 GMT
GitHub user vanzin opened a pull request:

    https://github.com/apache/spark/pull/14943

    [SPARK-15891][yarn] Clean up some logging in the YARN AM.

    To make the log file more readable, rework some of the logging done
    by the AM:
    
    - log executor command / env just once, since they're all almost the same;
      the information that changes, such as executor ID, is already available
      in other log messages.
    - avoid printing logs when nothing happens, especially when updating the
      container requests in the allocator.
    - print fewer log messages when requesting many unlocalized executors,
      instead of repeating the same message multiple times.
    - removed some logs that seemed unnecessary.
    
    In the process, I slightly fixed up the wording in a few log messages, and
    did some minor clean up of method arguments that were redundant.
    
    Tested by running existing unit tests, and analyzing the logs of an
    application that exercises dynamic allocation by forcing executors
    to be allocated and be killed in waves.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vanzin/spark SPARK-15891

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/14943.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14943
    
----
commit ef0c058a48fe021d347100e26f56e9835c236ac8
Author: Marcelo Vanzin <vanzin@cloudera.com>
Date:   2016-09-02T00:36:23Z

    [SPARK-15891][yarn] Clean up some logging in the YARN AM.
    
    To make the log file more readable, rework some of the logging done
    by the AM:
    
    - log executor command / env just once, since they're all almost the same;
      the information that changes, such as executor ID, is already available
      in other log messages.
    - avoid printing logs when nothing happens, especially when updating the
      container requests in the allocator.
    - print fewer log messages when requesting many unlocalized executors,
      instead of repeating the same message multiple times.
    - removed some logs that seemed unnecessary.
    
    In the process, I slightly fixed up the wording in a few log messages, and
    did some minor clean up of method arguments that were redundant.
    
    Tested by running existing unit tests, and analyzing the logs of an
    application that exercises dynamic allocation by forcing executors
    to be allocated and be killed in waves.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message