spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tejasapatil <...@git.apache.org>
Subject [GitHub] spark pull request #14910: [SPARK-17271] [SQL] Remove redundant `semanticEqu...
Date Thu, 01 Sep 2016 05:48:23 GMT
GitHub user tejasapatil opened a pull request:

    https://github.com/apache/spark/pull/14910

    [SPARK-17271] [SQL] Remove redundant `semanticEquals()` from `SortOrder`

    ## What changes were proposed in this pull request?
    
    Removing `semanticEquals()` from `SortOrder` because it can use the `semanticEquals()`
provided by its parent class (`Expression`). This was as per suggestion by @cloud-fan at https://github.com/apache/spark/pull/14841/files/7192418b3a26a14642fc04fc92bf496a954ffa5d#r77106801
    
    ## How was this patch tested?
    
    Ran the test added in https://github.com/apache/spark/pull/14841

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tejasapatil/spark SPARK-17271_remove_semantic_ordering

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/14910.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14910
    
----
commit 56eb55711581d68c9dbd6c01004f6f4cb45a7b6f
Author: Tejas Patil <tejasp@fb.com>
Date:   2016-09-01T05:44:14Z

    [SPARK-17271] [SQL] Remove redundant `semanticEquals()` from `SortOrder`

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message