spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayousterhout <...@git.apache.org>
Subject [GitHub] spark pull request #15249: [SPARK-17675] [CORE] Expand Blacklist for TaskSet...
Date Fri, 30 Sep 2016 21:48:45 GMT
Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15249#discussion_r81399719
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -592,34 +589,54 @@ private[spark] class TaskSetManager(
        * failures (this is because the method picks on unscheduled task, and then iterates
through each
        * executor until it finds one that the task hasn't failed on already).
        */
    -  private[scheduler] def abortIfCompletelyBlacklisted(executors: Iterable[String]): Unit
= {
    -
    -    val pendingTask: Option[Int] = {
    -      // usually this will just take the last pending task, but because of the lazy removal
    -      // from each list, we may need to go deeper in the list.  We poll from the end
because
    -      // failed tasks are put back at the end of allPendingTasks, so we're more likely
to find
    -      // an unschedulable task this way.
    -      val indexOffset = allPendingTasks.lastIndexWhere { indexInTaskSet =>
    -        copiesRunning(indexInTaskSet) == 0 && !successful(indexInTaskSet)
    -      }
    -      if (indexOffset == -1) {
    -        None
    -      } else {
    -        Some(allPendingTasks(indexOffset))
    -      }
    -    }
    +  private[scheduler] def abortIfCompletelyBlacklisted(
    +      hostToExecutors: HashMap[String, HashSet[String]]): Unit = {
    +    taskSetBlacklistOpt.foreach { taskSetBlacklist =>
    +        // If no executors have registered yet, don't abort the stage, just wait.  We
probably
    --- End diff --
    
    What about "Only look for unschedulable tasks when at least one executor has registered.
 Otherwise, task sets will be (unnecessarily) aborted in cases when no executors have registered
yet."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message