spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jodersky <...@git.apache.org>
Subject [GitHub] spark pull request #15257: [SPARK-17683][SQL] Support ArrayType in Literal.a...
Date Fri, 30 Sep 2016 21:04:34 GMT
Github user jodersky commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15257#discussion_r81417809
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
    @@ -60,6 +76,45 @@ object Literal {
       }
     
       /**
    +   * Returns the Spark SQL DataType for a given class object. Since this type needs to
be resolved
    +   * in runtime, we use match-case idioms for class objects here. However, there are
similar
    +   * functions in other files (e.g., HiveInspectors), so these functions need to merged
into one.
    +   */
    +  private[this] def componentTypeToDataType(clz: Class[_]): DataType = clz match {
    +    // primitive types
    +    case c: Class[_] if c == JavaShort.TYPE => ShortType
    --- End diff --
    
    hmm, I didn't think about my own advice: matching agains lowercase classOf[X] doesn't
work. So either `case _ if clz==classOf[]` or case c if c == classOf[]` are good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message