spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #15239: [SPARK-17665][SPARKR] Support options/mode all fo...
Date Fri, 30 Sep 2016 12:44:18 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15239#discussion_r81331357
  
    --- Diff: R/pkg/R/SQLContext.R ---
    @@ -328,6 +328,7 @@ setMethod("toDF", signature(x = "RDD"),
     #' It goes through the entire dataset once to determine the schema.
     #'
     #' @param path Path of file to read. A vector of multiple paths is allowed.
    +#' @param ... additional external data source specific named properties.
    --- End diff --
    
    Hm, do you think it is okay as it is? I tried to make them look more consistent but it
kind of failed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message