spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jodersky <...@git.apache.org>
Subject [GitHub] spark pull request #15257: [SPARK-17683][SQL] Support ArrayType in Literal.a...
Date Fri, 30 Sep 2016 03:22:55 GMT
Github user jodersky commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15257#discussion_r81273658
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
    @@ -46,12 +57,17 @@ object Literal {
         case s: String => Literal(UTF8String.fromString(s), StringType)
         case b: Boolean => Literal(b, BooleanType)
         case d: BigDecimal => Literal(Decimal(d), DecimalType(Math.max(d.precision, d.scale),
d.scale))
    -    case d: java.math.BigDecimal =>
    +    case d: JavaBigDecimal =>
           Literal(Decimal(d), DecimalType(Math.max(d.precision, d.scale), d.scale()))
         case d: Decimal => Literal(d, DecimalType(Math.max(d.precision, d.scale), d.scale))
         case t: Timestamp => Literal(DateTimeUtils.fromJavaTimestamp(t), TimestampType)
         case d: Date => Literal(DateTimeUtils.fromJavaDate(d), DateType)
         case a: Array[Byte] => Literal(a, BinaryType)
    +    case a: Array[_] =>
    --- End diff --
    
    @maropu, I tested my solution in a shell and it worked. To fix the compilation error,
simply make the overloaded method `ScalaReflection.dataTypeFor` public. I don't see any reason
for it being private in the first place, apart from it just being a default


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message