spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark issue #15299: [SPARK-17704][ML][MLlib] ChiSqSelector performance impro...
Date Thu, 29 Sep 2016 15:23:04 GMT
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/15299
  
    I don't think it can be transient, because if serialized, this data must be part of the
model. It is just an array of ints. I don't think lazy makes sense because it is just holding
on to an unsorted array to later sort it. But this is an array of, in any reasonable case,
less than a thousand elements. quicksorting it is trivial.
    
    Done, I added the selectedFeatures change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message