spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request #15276: [SPARK-17703][SQL] Add unnamed version of addRefe...
Date Thu, 29 Sep 2016 06:50:47 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15276#discussion_r81074127
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
    @@ -85,6 +85,27 @@ class CodegenContext {
       val references: mutable.ArrayBuffer[Any] = new mutable.ArrayBuffer[Any]()
     
       /**
    +   * Add an object to `references`.
    +   *
    +   * Returns the code to access it.
    +   */
    +  def addReferenceObj(obj: Any): String = {
    +    addReferenceObj(obj, null)
    +  }
    +
    +  /**
    +   * Add an object to `references`.
    +   *
    +   * Returns the code to access it.
    +   */
    +  def addReferenceObj(obj: Any, className: String): String = {
    --- End diff --
    
    Maybe add it when we need it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message