spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request #15248: [SPARK-17671] Spark 2.0 history server summary pa...
Date Wed, 28 Sep 2016 13:38:06 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15248#discussion_r80916950
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
    @@ -179,7 +180,11 @@ class HistoryServer(
       }
    --- End diff --
    
    So, should `getApplicationList()` even exist? it sounds like you'd never really want to
get the whole materialized list of apps. It looks like it's either called and filtered, or
called for its iterator. Is a deeper improvement here to just return an iterator from the
provider?
    
    Looking deeper, I suppose one issue here is that the underlying data structure this comes
from is mutable and changing. But then I think that means any view-based or iterator-based
result runs the risk of traversing it while it's modified. Hm.
    
    Maybe it's still no worse to do so, to return an iterator and immediately filter to get
the right subset copy, and proceed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message