spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sarutak <...@git.apache.org>
Subject [GitHub] spark pull request #14719: [SPARK-17154][SQL] Wrong result can be returned o...
Date Wed, 28 Sep 2016 06:52:39 GMT
Github user sarutak commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14719#discussion_r80852382
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
    @@ -672,6 +684,21 @@ class Analyzer(
         exprs.exists(_.find(_.isInstanceOf[UnresolvedDeserializer]).isDefined)
       }
     
    +  private[sql] def resolveExpressionFromSpecificLogicalPlan(
    +      nameParts: Seq[String],
    +      planToSearchFrom: LogicalPlan,
    +      targetPlanId: Long): Expression = {
    +    lazy val name = UnresolvedAttribute(nameParts).name
    +    planToSearchFrom.findByBreadthFirst(_.planId == targetPlanId) match {
    +      case Some(foundPlan) =>
    +        foundPlan.resolve(nameParts, resolver).getOrElse {
    +          failAnalysis(s"Could not find $name in ${foundPlan.output.mkString(", ")}")
    --- End diff --
    
    O.K, I'll just return the resolved result.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message