spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayousterhout <...@git.apache.org>
Subject [GitHub] spark pull request #15213: [SPARK-17644] [CORE] Do not add failedStages when...
Date Wed, 28 Sep 2016 05:37:13 GMT
Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15213#discussion_r80845506
  
    --- Diff: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
    @@ -2105,6 +2107,59 @@ class DAGSchedulerSuite extends SparkFunSuite with LocalSparkContext
with Timeou
         assert(scheduler.getShuffleDependencies(rddE) === Set(shuffleDepA, shuffleDepC))
       }
     
    +  test("After one stage is aborted for too many failed attempts, subsequent stages" +
    +    "still behave correctly on fetch failures") {
    +    def fetchFailJob: Unit = {
    +      val rdd1 = sc.makeRDD(Array(1, 2, 3, 4), 2).map(x => (x, 1)).groupByKey()
    +      val shuffleHandle =
    +        rdd1.dependencies.head.asInstanceOf[ShuffleDependency[_, _, _]].shuffleHandle
    +      rdd1.map {
    +        case (x, _) if (x == 1) =>
    +          throw new FetchFailedException(
    +            BlockManagerId("1", "1", 1), shuffleHandle.shuffleId, 0, 0, "test")
    +        case (x, _) => x
    +      }.count()
    +    }
    +
    +    def successJob: Unit = {
    --- End diff --
    
    and for this perhaps call it "runJobWithTemporaryFetchFailure" and then comment saying
"Runs a job that encounters a single fetch failure but succeeds on the second attempt"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message