spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ajbozarth <...@git.apache.org>
Subject [GitHub] spark pull request #15248: [SPARK-17671] Spark 2.0 history server summary pa...
Date Tue, 27 Sep 2016 20:04:49 GMT
Github user ajbozarth commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15248#discussion_r80779108
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
    @@ -178,6 +178,23 @@ class HistoryServer(
         provider.getListing()
       }
     
    +  /**
    +    * Returns a list of available applications, in descending order according to their
end time.
    +    *
    +    * @param limit the number of applications to return
    +    * @return List of known applications with a limit.
    +    */
    +  def getApplicationInfoList(limit: Int): Iterator[ApplicationInfo] = {
    +    val list =
    +      if (limit <= 0) {
    --- End diff --
    
    There's no need for this if/else, the take function has this behavior built in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message