spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request #15238: [SPARK-17653][SQL] Remove unnecessary distincts i...
Date Tue, 27 Sep 2016 17:49:57 GMT
Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15238#discussion_r80750444
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
    @@ -191,25 +191,34 @@ object ExtractFiltersAndInnerJoins extends PredicateHelper {
     
     /**
      * A pattern that collects all adjacent unions and returns their children as a Seq.
    + * If the top union is wrapped in a [[Distinct]], then the [[Distinct]] in the adjacent
unions, if
    + * any, will be eliminated.
      */
     object Unions {
    -  def unapply(plan: LogicalPlan): Option[Seq[LogicalPlan]] = plan match {
    -    case u: Union => Some(collectUnionChildren(mutable.Stack(u), Seq.empty[LogicalPlan]))
    +  def unapply(plan: LogicalPlan): Option[(Seq[LogicalPlan], Boolean)] = plan match {
    --- End diff --
    
    Why do we use an extractor here? We could just move this into the rule right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message