spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhuai <...@git.apache.org>
Subject [GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view
Date Mon, 26 Sep 2016 00:21:04 GMT
Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14897#discussion_r80395510
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/GlobalTempViewManager.scala
---
    @@ -0,0 +1,96 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.catalyst.catalog
    +
    +import javax.annotation.concurrent.GuardedBy
    +
    +import scala.collection.mutable
    +
    +import org.apache.spark.sql.AnalysisException
    +import org.apache.spark.sql.catalyst.analysis.TempTableAlreadyExistsException
    +import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
    +import org.apache.spark.sql.catalyst.util.StringUtils
    +
    +
    +/**
    + * A thread-safe manager for global temporary views, providing atomic operations to manage
them,
    + * e.g. create, update, remove, etc.
    + *
    + * Note that, the view name is always case-sensitive here, callers are responsible to
format the
    + * view name w.r.t. case-sensitive config.
    + */
    +class GlobalTempViewManager {
    +
    +  /** List of view definitions, mapping from view name to logical plan. */
    +  @GuardedBy("this")
    +  private val viewDefinitions = new mutable.HashMap[String, LogicalPlan]
    +
    +  def get(name: String): Option[LogicalPlan] = synchronized {
    +    viewDefinitions.get(name)
    +  }
    +
    +  def create(
    +      name: String,
    +      viewDefinition: LogicalPlan,
    +      overrideIfExists: Boolean): Unit = synchronized {
    +    if (!overrideIfExists && viewDefinitions.contains(name)) {
    +      throw new TempTableAlreadyExistsException(name)
    +    }
    +    viewDefinitions.put(name, viewDefinition)
    +  }
    +
    +  def update(
    +      name: String,
    +      viewDefinition: LogicalPlan): Boolean = synchronized {
    +    // Only update it when the view with the given name exits.
    +    if (viewDefinitions.contains(name)) {
    +      viewDefinitions.put(name, viewDefinition)
    +      true
    +    } else {
    +      false
    +    }
    +  }
    --- End diff --
    
    When do we use `update` and when do we use `create`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message