spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request #15213: [SPARK-17644] [CORE] Fix the race condition when ...
Date Fri, 23 Sep 2016 18:11:47 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15213#discussion_r80292431
  
    --- Diff: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
    @@ -2105,6 +2109,52 @@ class DAGSchedulerSuite extends SparkFunSuite with LocalSparkContext
with Timeou
         assert(scheduler.getShuffleDependencies(rddE) === Set(shuffleDepA, shuffleDepC))
       }
     
    +  test("The failed stage never resubmitted due to abort stage in another thread") {
    +    implicit val executorContext = ExecutionContext
    +      .fromExecutorService(Executors.newFixedThreadPool(5))
    +    val duration = 60.seconds
    +
    +    val f1 = Future {
    --- End diff --
    
    You can just use `failAfter(60.seconds) { ... }` to get rid of `ExecutionContext` and
`Future`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message