spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark issue #15102: [SPARK-17346][SQL] Add Kafka source for Structured Strea...
Date Fri, 23 Sep 2016 02:10:47 GMT
Github user marmbrus commented on the issue:

    https://github.com/apache/spark/pull/15102
  
    > "I want to be able to add a topicpartition mid stream, but I don't want to start
it from the beginning."
    
    I see, I was thinking only of new topics that appear that match your pattern.  I agree
that if/when we add that ability to add existing partitions midstream we'd probably need to
add two offsets in to the SQL offset for new partitions.
    
    > I think consistency in using json for any non-scalar values is worth 2 extra characters
per topic and 4 at the ends.
    
    I'd also support JSON here, but I would not mandate it (i.e. try json parsing and fall
back to comma separation).  Its not ambiguous, supports consistent usage, and doesn't penalize
the simple use cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message