spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request #15167: [SPARK-17418] Prevent kinesis-asl-assembly artifa...
Date Tue, 20 Sep 2016 22:09:19 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15167#discussion_r79723911
  
    --- Diff: external/kinesis-asl-assembly/pom.xml ---
    @@ -141,6 +141,21 @@
       <outputDirectory>target/scala-${scala.binary.version}/classes</outputDirectory>
       <testOutputDirectory>target/scala-${scala.binary.version}/test-classes</testOutputDirectory>
       <plugins>
    +    <!-- SPARK-17418: prevent the kinesis-asl-assembly from being published to Maven
-->
    +    <plugin>
    +      <groupId>org.apache.maven.plugins</groupId>
    +      <artifactId>maven-deploy-plugin</artifactId>
    +      <configuration>
    +        <skip>true</skip>
    +      </configuration>
    +    </plugin>
    +    <plugin>
    +      <groupId>org.apache.maven.plugins</groupId>
    +      <artifactId>maven-install-plugin</artifactId>
    --- End diff --
    
    We need to do this in order to prevent this artifact from being published to a release
staging repository, since the current release publishing scripts work by first installing
the components to be published into a fresh temporary Maven repository and then searching
that repository for artifacts, signing them, and uploading them to the staging repository
using `curl`. See https://github.com/apache/spark/blob/7e418e99cff4cf512ab2a9fa74221c4655048c8d/dev/create-release/release-build.sh#L294


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message