spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #15145: [SPARK-17589] [TEST] [2.0] Fix test case `create ...
Date Mon, 19 Sep 2016 12:02:15 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15145#discussion_r79375663
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala
---
    @@ -509,7 +509,7 @@ class MetastoreDataSourcesSuite extends QueryTest with SQLTestUtils
with TestHiv
               assert(
                 intercept[AnalysisException] {
                   sparkSession.catalog.createExternalTable("createdJsonTable", jsonFilePath.toString)
    -            }.getMessage.contains("Table default.createdJsonTable already exists."),
    +            }.getMessage.contains("Table `default`.`createdJsonTable` already exists."),
    --- End diff --
    
    The master also code use `unquotedString` here, let's fix it first, and we can discuss
about the choice between `quotedString` and `unquotedString` later


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message