spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From skonto <>
Subject [GitHub] spark pull request #14650: [SPARK-17062][MESOS] add conf option to mesos dis...
Date Mon, 19 Sep 2016 10:01:41 GMT
Github user skonto commented on a diff in the pull request:
    --- Diff: core/src/main/scala/org/apache/spark/util/Executable.scala ---
    @@ -0,0 +1,25 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.util
    + * Adds main method to a class or object
    + */
    +private[spark] trait Executable {
    --- End diff --
    I needed to mark specific classes with main support, I could have used a different implementation
to find out about it like duck typing, or reflection etc but these are either not permitted
(eg. scala style) or are too complex. It is not bad to tag a class that way. Maybe sound redundant
even funny (I would not call that way) but it serves a purpose to make things easily testable.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message