spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wzhfy <...@git.apache.org>
Subject [GitHub] spark pull request #15090: [SPARK-17073] [SQL] generate column-level statist...
Date Sun, 18 Sep 2016 05:29:59 GMT
Github user wzhfy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15090#discussion_r79297872
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
---
    @@ -98,8 +98,12 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder {
           ctx.identifier != null &&
           ctx.identifier.getText.toLowerCase == "noscan") {
           AnalyzeTableCommand(visitTableIdentifier(ctx.tableIdentifier).toString)
    -    } else {
    +    } else if (ctx.identifierSeq() == null) {
    --- End diff --
    
    As mentioned in  [the comment](https://github.com/apache/spark/pull/15090#r78687294),
we are going to change the "ANALYZE" syntax in SqlBase.g4, i.e. make the identifierSeq non-optional,
which it's different from Hive. Is this ok? @rxin @hvanhovell 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message