spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From willb <>
Subject [GitHub] spark pull request #15105: [SPARK-17548] [MLlib] Word2VecModel.findSynonyms ...
Date Thu, 15 Sep 2016 14:18:11 GMT
Github user willb commented on a diff in the pull request:
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
    @@ -566,8 +582,8 @@ class Word2VecModel private[spark] (
    -      .take(num + 1)
    -      .tail
    +      .filter(tup => => !w.equals(tup._1)).getOrElse(true) &&
tup._2 != 1.0d)
    --- End diff --
    @hhbyyh So [one of the python doctests](
depends on a word not being a synonym of its vector representation.  I think since this is
the documented behavior now, that's the direction the fix should go as well, but I'll use
`Vector.equals` instead of checking similarity in any case.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message