spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgravescs <...@git.apache.org>
Subject [GitHub] spark pull request #15069: [SPARK-17511] Yarn Dynamic Allocation: Avoid mark...
Date Tue, 13 Sep 2016 14:05:01 GMT
Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15069#discussion_r78565120
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
    @@ -506,36 +505,41 @@ private[yarn] class YarnAllocator(
             allocatedContainerToHostMap.put(containerId, executorHostname)
           }
     
    -      if (launchContainers) {
    -        launcherPool.execute(new Runnable {
    -          override def run(): Unit = {
    -            try {
    -              new ExecutorRunnable(
    -                Some(container),
    -                conf,
    -                sparkConf,
    -                driverUrl,
    -                executorId,
    -                executorHostname,
    -                executorMemory,
    -                executorCores,
    -                appAttemptId.getApplicationId.toString,
    -                securityMgr,
    -                localResources
    -              ).run()
    -              updateInternalState()
    -            } catch {
    -              case NonFatal(e) =>
    -                logError(s"Failed to launch executor $executorId on container $containerId",
e)
    -                // Assigned container should be released immediately to avoid unnecessary
resource
    -                // occupation.
    -                amClient.releaseAssignedContainer(containerId)
    +      if (numExecutorsRunning < targetNumExecutors) {
    --- End diff --
    
    could you add a basic unit test in the YarnAllocatorSuite for this. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message