spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clockfly <...@git.apache.org>
Subject [GitHub] spark pull request #15024: [SPARK-17470][SQL] unify path for data source tab...
Date Mon, 12 Sep 2016 23:15:54 GMT
Github user clockfly commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15024#discussion_r78472224
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
    @@ -435,13 +435,13 @@ case class DataSource(
             //  1. Only one output path can be specified on the write path;
             //  2. Output path must be a legal HDFS style file system path;
             //  3. It's OK that the output path doesn't exist yet;
    -        val caseInsensitiveOptions = new CaseInsensitiveMap(options)
    -        val outputPath = {
    -          val path = new Path(caseInsensitiveOptions.getOrElse("path", {
    -            throw new IllegalArgumentException("'path' is not specified")
    -          }))
    +        val allPaths = paths ++ new CaseInsensitiveMap(options).get("path")
    +        val outputPath = if (allPaths.length == 1) {
    +          val path = new Path(allPaths.head)
               val fs = path.getFileSystem(sparkSession.sessionState.newHadoopConf())
               path.makeQualified(fs.getUri, fs.getWorkingDirectory)
    +        } else {
    +          throw new IllegalArgumentException("Only one path can be specified on the write
path")
    --- End diff --
    
    Is IllegalArgumentException a proper message type? It is a RuntimeException used when
calling a method with reflection but passing different argument type.
    
    ```
    /**
     * Thrown to indicate that a method has been passed an illegal or
     * inappropriate argument.
     *
     * @author  unascribed
     * @since   JDK1.0
     */
    ``` 
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message