spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhuai <...@git.apache.org>
Subject [GitHub] spark pull request #15056: [SPARK-17503][Core] Fix memory leak in Memory sto...
Date Mon, 12 Sep 2016 18:23:52 GMT
Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15056#discussion_r78426904
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
    @@ -663,31 +663,43 @@ private[spark] class MemoryStore(
     private[storage] class PartiallyUnrolledIterator[T](
         memoryStore: MemoryStore,
         unrollMemory: Long,
    -    unrolled: Iterator[T],
    +    private[this] var unrolled: Iterator[T],
         rest: Iterator[T])
       extends Iterator[T] {
     
    -  private[this] var unrolledIteratorIsConsumed: Boolean = false
    -  private[this] var iter: Iterator[T] = {
    -    val completionIterator = CompletionIterator[T, Iterator[T]](unrolled, {
    -      unrolledIteratorIsConsumed = true
    -      memoryStore.releaseUnrollMemoryForThisTask(MemoryMode.ON_HEAP, unrollMemory)
    -    })
    -    completionIterator ++ rest
    --- End diff --
    
    oh, yea, you are right.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message